sw: Runtime Fixes #166
Merged
sw: Runtime Fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colluca
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two fixes to the Snitch runtime that are required for Deeploy.
The first issue is related to the location of the
snrt_l1_allocator()which is calculated via thecls()function. This function uses the_cls_ptrwhich is placed at the beginning of the.cbsssection. However, if the.cbsssection is empty, this location is invalid.The second fix statically allocated the buffers for multicore compatible
printf()function. Without this fix, the buffers overlap with the L3 allocator, causingprintf()call to overwrite the allocation structure.Fixed
.cbsssection is not optimized away.printf()buffers