Skip to content

Commit

Permalink
container: Set PATH variables correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
fischeti committed Sep 4, 2024
1 parent fe1686e commit f6b288c
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions util/container/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,13 @@ RUN ${VIRTUAL_ENV}/bin/pip install --upgrade pip && \
${VIRTUAL_ENV}/bin/pip install .

# Copy the tools from the builder stage
COPY --from=builder /tools/bender bin/
COPY --from=builder /root/.cargo/bin/banshee bin/
COPY --from=builder /tools/doxygen/bin/doxygen bin/
COPY --from=builder /tools/verible* bin/
COPY --from=builder /tools/bender /tools/bin/
COPY --from=builder /root/.cargo/bin/banshee /tools/bin/
COPY --from=builder /tools/doxygen/bin/doxygen /tools/bin/
COPY --from=builder /tools/verible* /tools/bin/
COPY --from=verilator /usr/local/bin/verilator* /usr/local/bin/

# Modify environment and path variables
ENV VLT_ROOT="/usr/local/bin/verilator/"
ENV PATH="${VIRTUAL_ENV}/bin:${PATH}"
ENV PATH "/tools/bin:${PATH}"

Check warning on line 141 in util/container/Dockerfile

View workflow job for this annotation

GitHub Actions / Deploy Docker image

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

0 comments on commit f6b288c

Please sign in to comment.