hw: Improve performance counters for bring-up (#155)

Co-authored-by: Milos Hirsl <[email protected]>
Co-authored-by: Luca Colagrande <[email protected]>

.github/workflows/lint.yml

@@ -20,8 +20,6 @@ jobs:
         with:
           paths: |
             ./hw
-          exclude_paths: |
-            ./hw/future/test
           github_token: ${{ secrets.GITHUB_TOKEN }}
           fail_on_error: true
           reviewdog_reporter: github-check
@@ -39,22 +37,34 @@ jobs:
         uses: pulp-platform/pulp-actions/[email protected]
 
   ######################
-  # Opcodes Up-to-Date #
+  # Sources Up-to-Date #
   ######################
-  check-opcodes:
-    name: Check Opcodes Up-to-Date
-    runs-on: ubuntu-latest
+  sources-up-to-date:
+    name: Check Sources Up-to-Date
+    runs-on: ubuntu-22.04
+    container:
+      image: ghcr.io/pulp-platform/snitch_cluster:main
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
-      - name: Update opcodes and diff
+      - name: Generate opcodes
         run: |
           ./util/generate-opcodes.sh
+      - name: Generate RTL sources
+        working-directory: target/snitch_cluster
+        run: |
+          make rtl
+      # For some reason, the checkout is done by a different user,
+      # than that running `git diff` (root, possibly due to Docker).
+      # So we need to set the repository as a safe directory.
+      - name: Git config safe.directory
+        run: |
+          git config --global --add safe.directory $GITHUB_WORKSPACE
       - name: Diff porcelain
         uses: mmontes11/[email protected]
         with:
-          message: Found differences, please update all opcode
+          message: Found differences, please update all sources
 
   #################
   # Check License #

hw/snitch_cluster/src/snitch_cluster.sv

@@ -510,9 +510,9 @@ module snitch_cluster
   tcdm_req_t [NrTCDMPortsCores-1:0] tcdm_req;
   tcdm_rsp_t [NrTCDMPortsCores-1:0] tcdm_rsp;
 
-  core_events_t [NrCores-1:0] core_events;
-  tcdm_events_t               tcdm_events;
-  dma_events_t                dma_events;
+  core_events_t [NrCores-1:0]                      core_events;
+  tcdm_events_t                                    tcdm_events;
+  dma_events_t [DMANumChannels-1:0]                dma_events;
   snitch_icache_pkg::icache_events_t [NrCores-1:0] icache_events;
 
   // 4. Memory Subsystem (Core side).
@@ -959,7 +959,7 @@ module snitch_cluster
           assign wide_axi_mst_req[SDMAMst + j] = axi_dma_req[j];
           assign axi_dma_res[j] = wide_axi_mst_rsp[SDMAMst + j];
         end
-        assign dma_events = dma_core_events[0]; // Only first channel is tracked
+        assign dma_events = dma_core_events;
       end
   end
 
@@ -1237,20 +1237,19 @@ module snitch_cluster
   );
 
   snitch_cluster_peripheral #(
-    .AddrWidth (PhysicalAddrWidth),
     .reg_req_t (reg_req_t),
     .reg_rsp_t (reg_rsp_t),
     .tcdm_events_t (tcdm_events_t),
     .dma_events_t (dma_events_t),
-    .NrCores (NrCores)
+    .NrCores (NrCores),
+    .DMANumChannels (DMANumChannels)
   ) i_snitch_cluster_peripheral (
     .clk_i,
     .rst_ni,
     .reg_req_i (reg_req),
     .reg_rsp_o (reg_rsp),
     .icache_prefetch_enable_o (icache_prefetch_enable),
     .cl_clint_o (cl_interrupt),
-    .cluster_hart_base_id_i (hart_base_id_i),
     .core_events_i (core_events),
     .tcdm_events_i (tcdm_events),
     .dma_events_i (dma_events),