Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor network functions #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

lukamac
Copy link
Contributor

@lukamac lukamac commented Nov 14, 2023

While working on drone code, we noticed that there was redundant code in the network run function so I moved some code to the initializer.
Alongside that I aligned a little bit more the common and gap9 network templates in hopes to merge them completely soon.

@lukamac lukamac requested a review from ABurrello November 14, 2023 22:04
@lukamac lukamac force-pushed the lukamac/pr/refactor-network branch from 71abe5e to 30a99a9 Compare November 14, 2023 22:13
@ABurrello
Copy link
Collaborator

I see that checks have failed. Please check that the modifications do not alternate the tests. Additionally, it would be needed in future to also add tests for GAP9 in the CI

@lukamac
Copy link
Contributor Author

lukamac commented Nov 15, 2023

Yes, I will fix the problems ofc. Regarding the gap9 tests in CI is a bit more difficult because we use the private gap_sdk. It is possible to add a test on our private gitlab, but it requires effort and time which I don't have right now. If anyone is interested in doing it, I can pass the info I have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants