hw: Fix CVA6 debug module addresses #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two errors in the debug module addresses passed to CVA6: 1. `HaltAddress` and `ExceptionAddress` are assumed to be relative to `DmBaseAddress`, see https://github.com/pulp-platform/cva6/blob/99ae53bde1a94b90c1d9bbbe7fe272a9336200a6/core/frontend/frontend.sv#L380 and https://github.com/pulp-platform/cva6/blob/99ae53bde1a94b90c1d9bbbe7fe272a9336200a6/core/csr_regfile.sv#L2295. Coincidentally, this currently does not cause any issues since `AmDbg = '0`, 2. `ExceptionAddress` was changed from `0x808` to `0x810` in pulp-platform/riscv-dbg#145, which is included in the debug module version used in Cheshire. This means that exceptions in debug mode currently cause CVA6 to jump to `resume` and return from debug mode instead of handling the exception, which breaks several openocd commands that use exceptions to discover CSR availabilities. Signed-off-by: Nils Wistoff <[email protected]>
paulsc96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two errors in the debug module addresses passed to CVA6:
HaltAddressandExceptionAddressare assumed to be relative toDmBaseAddress, see here andhere. In Cheshire, they are currently assigned their absolute address. Coincidentally, this currently does not cause any issues since
AmDbg = '0,ExceptionAddresswas changed from0x808to0x810in [fix] Realign addresses to 64-bit riscv-dbg#145, which is included in the debug module version used in Cheshire. This means that exceptions in debug mode currently cause CVA6 to jump toresumeand return from debug mode instead of handling the exception, which breaks several openocd commands that rely on exceptions to discover CSR availabilities.