Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cheshire_xilinx_top when USE_RESETN is undefined, wire sys_resetn is used but not declared. #172

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aquaticfuller
Copy link
Collaborator

No description provided.

@paulsc96 paulsc96 changed the base branch from ck/flamingo to main December 16, 2024 16:35
@paulsc96 paulsc96 force-pushed the zx/flamingo_xilinx_fix branch from fdbeab2 to 9df5811 Compare December 16, 2024 16:46
Copy link
Collaborator

@paulsc96 paulsc96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I rebased this and cleaned it up for inclusion in main, but I am genuinely confused why you did this as it seems pointless.

When USE_RESETN is not defined, USE_RESET must be defined as things are currently implemented (admittedly a flawed design, but it's not my code).

However in this case, sys_resetn is declared and assigned to be ~sys_reset, so your change does not do anything.

Is there something I don't see here?

@Aquaticfuller
Copy link
Collaborator Author

Hi!
That is because I'm working on Flamingo, which doesn't use the cheshire_top_xilinx as its top level, instead it has another xilinx top module, and none of the macros are defined. But when the video processes that file, it returns an error about this. It might make more sense to directly remove this file from the Bender.yml of the Cheshire used by Flamingo.

@paulsc96
Copy link
Collaborator

Okay, that seems reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants