Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astral rebase #101

Closed
wants to merge 40 commits into from
Closed

Astral rebase #101

wants to merge 40 commits into from

Conversation

yvantor
Copy link
Contributor

@yvantor yvantor commented Feb 11, 2024

Rebasing on main and fixing the workflow.

alex96295 and others added 30 commits November 22, 2023 17:35
* hw: Remove obsolete typedef

* sw/deps: Use HTTP reference for CVA6 SDK
* Add correct compile command to quick start instructions

* Add correct questa compile command to docs

---------

Co-authored-by: sem23h24 Luka Guzenko (lguzenko) <[email protected]>
As of #56, multiple cores are supported.

Signed-off-by: Nils Wistoff <[email protected]>
Adding support for atomics, see pulp-platform/unbent#2

Signed-off-by: Nils Wistoff <[email protected]>
* Fix bug in perf counter when no events
@paulsc96
Copy link
Collaborator

paulsc96 commented Feb 14, 2024

I will convert this to a draft, since surely you are kidding with this being ready for review.

EDIT: Just realizing now that this does not target main. Why merge main back into a non-main branch instead of rebasing, and why pull-request it? Closed.

@paulsc96 paulsc96 marked this pull request as draft February 14, 2024 13:03
@paulsc96 paulsc96 closed this Feb 14, 2024
@yvantor
Copy link
Contributor Author

yvantor commented Feb 14, 2024

The non-main branch you are mentioning is temporarily a reference for a project, and since there will be other people using and updating it I have opened a merge request for it in order to not force-push directly there... The plan is to later (short term) evaluate the possibility to merge the features in the main, but it needs discussion first that is planned for this week before actually proposing merging such features.

@alex96295
Copy link
Collaborator

alex96295 commented Feb 15, 2024

Since the PR was not targeting main and is part of the development flow of the astral branch, I would re-open it.

Once the astral branch is ready, a PR will be opened targeting main with the feature to be added (dual lockstep for cva6), and we will review it and ask for cleanup as usual etc

Until then I think it's not our business :)

@alex96295 alex96295 reopened this Feb 15, 2024
@yvantor yvantor deleted the branch astral March 4, 2024 16:22
@yvantor yvantor closed this Mar 4, 2024
Aquaticfuller pushed a commit that referenced this pull request Jul 16, 2024
Add CVA6 bare-metal boot from Security Island
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants