Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix script when specifying multiple --only-* #153

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

micprog
Copy link
Member

@micprog micprog commented Jan 23, 2024

Ensure defines/includes/sources are included in script when specifying multiple --only-*.

Ensure defines/includes/sources are included in script when specifying
multiple `--only-*`.
@micprog micprog requested review from fischeti and CyrilKoe January 23, 2024 13:02
Copy link

@CyrilKoe CyrilKoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, tested with Carifled's Vivado block design flow

Copy link

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only suggestion I have is that --only-* commands should be mutually exclusive to each other. Changing them to --no-* would make more sense to me.

@micprog
Copy link
Member Author

micprog commented Jan 24, 2024

LGTM. The only suggestion I have is that --only-* commands should be mutually exclusive to each other. Changing them to --no-* would make more sense to me.

While I agree, I think for now, it makes more sense to keep the existing behavior prior to the template change. This just ensures the behavior from before #120 continues working.

@micprog micprog merged commit 962b8c5 into master Jan 24, 2024
6 checks passed
@micprog micprog deleted the fix-script-only branch January 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants