-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCS and Verilator support #358
VCS and Verilator support #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which tool is upset with using the values from the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verilator cannot compile with the following error:
%Error: Internal Error: src/axi_sim_mem.sv:119:34: ../V3Width.cpp:7074: Node has no type:
119 | axi_pkg::resp_t rerr[addr_t] = '{default: axi_pkg::RESP_OKAY};
| ^~
... See the manual at https://verilator.org/verilator_doc.html for more assistance.
I tried different ways of re-writing using casting and other approaches, but it just does not work with Verilator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, can you then keep the link to the package as a comment and write a note why this was changed? Please open an issue for that on the verilator page to have this eventually fixed in the simulator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. Can you change the parameters to int unsigned
directly?
Also, why don't we reference the package anymore for the AXI response in the simulation memory?
4f25d85
to
648c65f
Compare
648c65f
to
93e8a6f
Compare
I updated the pull request as requested. |
Minimal changes required to compile sources and simulation targets for VCS (version W-2024.09-1) and Verilator (v5.028-44-g1d79f5c59):
std::
prefix when using built-in classes likestd::semaphore
andstd::mailbox
.parameter
andparameter int
are not the same.