Skip to content

Commit

Permalink
sim: Reduce debug print messages and remove warnings (#17)
Browse files Browse the repository at this point in the history
* chimney: Get rid of mismatch warnings for `rob_idx`

* dma: Disable debug prints
  • Loading branch information
fischeti authored Nov 13, 2023
1 parent d80fadf commit 54747cc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 17 deletions.
29 changes: 13 additions & 16 deletions src/floo_narrow_wide_chimney.sv
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,6 @@ module floo_narrow_wide_chimney
input floo_wide_t floo_wide_i
);

typedef logic [$clog2(NarrowReorderBufferSize)-1:0] narrow_rob_idx_t;
typedef logic [$clog2(WideReorderBufferSize)-1:0] wide_rob_idx_t;

// Duplicate AXI port signals to degenerate ports
// in case they are not used
axi_narrow_in_req_t axi_narrow_req_in;
Expand Down Expand Up @@ -172,15 +169,15 @@ module floo_narrow_wide_chimney
typedef struct packed {
axi_narrow_in_id_t id;
logic rob_req;
narrow_rob_idx_t rob_idx;
rob_idx_t rob_idx;
id_t src_id;
logic atop;
} narrow_id_out_buf_t;

typedef struct packed {
axi_wide_in_id_t id;
logic rob_req;
wide_rob_idx_t rob_idx;
rob_idx_t rob_idx;
id_t src_id;
} wide_id_out_buf_t;

Expand Down Expand Up @@ -375,35 +372,35 @@ module floo_narrow_wide_chimney
// AW/B RoB
axi_narrow_in_b_chan_t axi_narrow_b_rob_out, axi_narrow_b_rob_in;
logic narrow_aw_rob_req_out;
narrow_rob_idx_t narrow_aw_rob_idx_out;
rob_idx_t narrow_aw_rob_idx_out;
logic narrow_aw_rob_valid_out, narrow_aw_rob_ready_in;
logic narrow_aw_rob_valid_in, narrow_aw_rob_ready_out;
logic narrow_b_rob_valid_in, narrow_b_rob_ready_out;
logic narrow_b_rob_valid_out, narrow_b_rob_ready_in;
axi_wide_in_b_chan_t axi_wide_b_rob_out, axi_wide_b_rob_in;
logic wide_aw_rob_req_out;
narrow_rob_idx_t wide_aw_rob_idx_out;
rob_idx_t wide_aw_rob_idx_out;
logic wide_aw_rob_valid_out, wide_aw_rob_ready_in;
logic wide_b_rob_valid_in, wide_b_rob_ready_out;
logic wide_b_rob_valid_out, wide_b_rob_ready_in;

// AR/R RoB
axi_narrow_in_r_chan_t axi_narrow_r_rob_out, axi_narrow_r_rob_in;
logic narrow_ar_rob_req_out;
narrow_rob_idx_t narrow_ar_rob_idx_out;
rob_idx_t narrow_ar_rob_idx_out;
logic narrow_ar_rob_valid_out, narrow_ar_rob_ready_in;
logic narrow_r_rob_valid_in, narrow_r_rob_ready_out;
logic narrow_r_rob_valid_out, narrow_r_rob_ready_in;
axi_wide_in_r_chan_t axi_wide_r_rob_out, axi_wide_r_rob_in;
logic wide_ar_rob_req_out;
wide_rob_idx_t wide_ar_rob_idx_out;
rob_idx_t wide_ar_rob_idx_out;
logic wide_ar_rob_valid_out, wide_ar_rob_ready_in;
logic wide_r_rob_valid_in, wide_r_rob_ready_out;
logic wide_r_rob_valid_out, wide_r_rob_ready_in;

logic narrow_b_rob_rob_req;
logic narrow_b_rob_last;
narrow_rob_idx_t narrow_b_rob_rob_idx;
rob_idx_t narrow_b_rob_rob_idx;
assign narrow_b_rob_rob_req = floo_rsp_in.narrow_b.hdr.rob_req;
assign narrow_b_rob_rob_idx = floo_rsp_in.narrow_b.hdr.rob_idx;
assign narrow_b_rob_last = floo_rsp_in.narrow_b.hdr.last;
Expand Down Expand Up @@ -459,7 +456,7 @@ module floo_narrow_wide_chimney

logic wide_b_rob_rob_req;
logic wide_b_rob_last;
narrow_rob_idx_t wide_b_rob_rob_idx;
rob_idx_t wide_b_rob_rob_idx;
assign wide_b_rob_rob_req = floo_rsp_in.wide_b.hdr.rob_req;
assign wide_b_rob_rob_idx = floo_rsp_in.wide_b.hdr.rob_idx;
assign wide_b_rob_last = floo_rsp_in.wide_b.hdr.last;
Expand All @@ -473,7 +470,7 @@ module floo_narrow_wide_chimney
.ax_id_t ( axi_wide_in_id_t ),
.rsp_chan_t ( axi_wide_in_b_chan_t ),
.rsp_meta_t ( axi_wide_in_b_chan_t ),
.rob_idx_t ( narrow_rob_idx_t ),
.rob_idx_t ( rob_idx_t ),
.dest_t ( id_t ),
.sram_cfg_t ( sram_cfg_t )
) i_wide_b_rob (
Expand Down Expand Up @@ -516,7 +513,7 @@ module floo_narrow_wide_chimney

logic narrow_r_rob_rob_req;
logic narrow_r_rob_last;
narrow_rob_idx_t narrow_r_rob_rob_idx;
rob_idx_t narrow_r_rob_rob_idx;
assign narrow_r_rob_rob_req = floo_rsp_in.narrow_r.hdr.rob_req;
assign narrow_r_rob_rob_idx = floo_rsp_in.narrow_r.hdr.rob_idx;
assign narrow_r_rob_last = floo_rsp_in.narrow_r.hdr.last;
Expand All @@ -531,7 +528,7 @@ module floo_narrow_wide_chimney
.rsp_chan_t ( axi_narrow_in_r_chan_t ),
.rsp_data_t ( axi_narrow_in_data_t ),
.rsp_meta_t ( narrow_meta_t ),
.rob_idx_t ( narrow_rob_idx_t ),
.rob_idx_t ( rob_idx_t ),
.dest_t ( id_t ),
.sram_cfg_t ( sram_cfg_t )
) i_narrow_r_rob (
Expand Down Expand Up @@ -560,7 +557,7 @@ module floo_narrow_wide_chimney

logic wide_r_rob_rob_req;
logic wide_r_rob_last;
wide_rob_idx_t wide_r_rob_rob_idx;
rob_idx_t wide_r_rob_rob_idx;
assign wide_r_rob_rob_req = floo_wide_in.wide_r.hdr.rob_req;
assign wide_r_rob_rob_idx = floo_wide_in.wide_r.hdr.rob_idx;
assign wide_r_rob_last = floo_wide_in.wide_r.hdr.last;
Expand All @@ -575,7 +572,7 @@ module floo_narrow_wide_chimney
.rsp_chan_t ( axi_wide_in_r_chan_t ),
.rsp_data_t ( axi_wide_in_data_t ),
.rsp_meta_t ( wide_meta_t ),
.rob_idx_t ( wide_rob_idx_t ),
.rob_idx_t ( rob_idx_t ),
.dest_t ( id_t ),
.sram_cfg_t ( sram_cfg_t )
) i_wide_r_rob (
Expand Down
2 changes: 1 addition & 1 deletion test/floo_dma_test_node.sv
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ module floo_dma_test_node #(
// debug
localparam bit Debug = 1'b0;
localparam bit ModelOutput = 1'b0;
localparam bit PrintFifoInfo = 1'b1;
localparam bit PrintFifoInfo = 1'b0;

// dependent parameters
localparam int unsigned StrbWidth = DataWidth / 8;
Expand Down

0 comments on commit 54747cc

Please sign in to comment.