Index collection memberships from Figgy. #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precursor to #283
tpendragon
force-pushed
the
index_collections
branch
from
3c3b47f to
1e98b38
Compare
hackartisan
requested changes
Jan 4, 2021
| @@ -47,7 +47,8 @@ def output | |||
| "date_created" => date_created, | |||
| "description" => description, | |||
| "series" => series, | |||
| "provenance" => provenance | |||
| "provenance" => provenance, | |||
| "collections_label" => collections | |||
There was a problem hiding this comment.
Maybe call this collection_labels since it's a multivalue field
There was a problem hiding this comment.
I can't, the wildcard field is _label in the solr schema.
|
|
||
| def eligible_collections | ||
| Array.wrap(json["memberOf"]).select do |member| | ||
| member["barcode"].blank? && member["title"] != "Latin American Ephemera" |
There was a problem hiding this comment.
Can you add a comment explaining these checks?
hackartisan
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precursor to #283