Allow only non-empty extension to check support

pug-php · Mar 5, 2023 · 5395257 · 5395257
1 parent b0aefcd
commit 5395257
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/src/Pug/PugSymfonyEngine.php b/src/Pug/PugSymfonyEngine.php
@@ -256,7 +256,7 @@ public function exists($name): bool
     public function supports($name): bool
     {
         foreach ($this->getOptionDefault('extensions', ['.pug', '.jade']) as $extension) {
-            if (str_ends_with($name, $extension)) {
+            if ($extension && str_ends_with($name, $extension)) {
                 return true;
             }
         }

diff --git a/src/Pug/Symfony/Traits/HelpersHandler.php b/src/Pug/Symfony/Traits/HelpersHandler.php
@@ -352,9 +352,10 @@ protected function getHttpFoundationExtension(): HttpFoundationExtension
         $stack = $this->stack ?? $this->container->get('request_stack');
 
         /* @var RequestContext $context */
-        $context = $this->context ?? ($this->container->has('router.request_context')
-            ? $this->container->get('router.request_context')
-            : $this->container->get('router')->getContext()
+        $context = $this->context ?? (
+            $this->container->has('router.request_context')
+                ? $this->container->get('router.request_context')
+                : $this->container->get('router')->getContext()
         );
 
         return new HttpFoundationExtension(new UrlHelper($stack, $context));

diff --git a/tests/Pug/PugSymfonyEngineTest.php b/tests/Pug/PugSymfonyEngineTest.php
@@ -115,7 +115,7 @@ public function testRequireTwig()
         self::expectException(RuntimeException::class);
         self::expectExceptionMessage('Twig needs to be configured.');
 
-        $object = new class () {
+        $object = new class() {
             use HelpersHandler;
 
             public function wrongEnhance(): void
@@ -382,7 +382,7 @@ public function testAssetHelperPhp()
                 '/<div( class="[^"]+")(.+?)></',
                 '<div$2$1><',
                 strtr(trim($pugSymfony->render('style-php.pug')), [
-                    "\r" => '',
+                    "\r"     => '',
                     '&#039;' => "'",
                 ]),
             ),
@@ -410,7 +410,7 @@ public function testAssetHelperJs()
                 '/<div( class="[^"]+")(.+?)></',
                 '<div$2$1><',
                 strtr(trim($pugSymfony->render('style-js.pug')), [
-                    "\r" => '',
+                    "\r"     => '',
                     '&#039;' => "'",
                 ]),
             ),
@@ -534,7 +534,7 @@ public function testCustomPaths()
     public function testMissingDir()
     {
         self::expectExceptionObject(new CompilerException(
-            new SourceLocation('page.pug', 1,0),
+            new SourceLocation('page.pug', 1, 0),
             'Source file page.pug not found',
         ));