[try] Travis to github actions #1491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 6fd441e and detected 0 issues on this pull request. View more on Code Climate. |
|
Hey @cesswairimu, I noticed the Travis build is being triggered instead of the new GitHub. Have you removed the travis config workflow files? That could possibly explain the travis workflow being triggered |
jywarren
reviewed
Jun 10, 2021
| with: | ||
| ruby-version: 2.4.6 | ||
| bundler-cache: true | ||
| - uses: ./.github/actions/setup-test-environment |
There was a problem hiding this comment.
Aha - ok so this is missing this file, which we made in plots2 to reduce the length of the script: https://github.com/publiclab/plots2/blob/main/.github/actions/setup-test-environment/action.yml
There was a problem hiding this comment.
Trying this in SWB here: publiclab/spectral-workbench#647
There was a problem hiding this comment.
aha! thanks Jeff ...will look into it
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1489 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!