-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump grunt-contrib-jasmine from 1.0.3 to 2.0.3 #168
base: main
Are you sure you want to change the base?
Bump grunt-contrib-jasmine from 1.0.3 to 2.0.3 #168
Conversation
99e22ed
to
4139f9f
Compare
4139f9f
to
b721d01
Compare
63eedb5
to
300b38a
Compare
@dependabot rebase |
300b38a
to
dcfa4fd
Compare
OK, looks like maybe a breaking change in how Jasmine tasks are formatted?
|
dcfa4fd
to
62e63f8
Compare
@dependabot rebase |
Bumps [grunt-contrib-jasmine](https://github.com/gruntjs/grunt-contrib-jasmine) from 1.0.3 to 2.0.3. - [Release notes](https://github.com/gruntjs/grunt-contrib-jasmine/releases) - [Changelog](https://github.com/gruntjs/grunt-contrib-jasmine/blob/master/CHANGELOG) - [Commits](gruntjs/grunt-contrib-jasmine@v1.0.3...v2.0.3) Signed-off-by: dependabot[bot] <[email protected]>
62e63f8
to
b54eafe
Compare
Some guidance on upgrading to Jasmine 2.0 here:
Oh, oops. Here we're only updateing |
This now uses Chrome Headless, which may be an issue? https://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-puppeteer-on-travis-ci |
Also seeing:
Maybe we need to include puppeteer in our |
OK - lots of useful errors now. Deprecating Node v5 and v6, the other Travis tests now return more useful errors. |
Mostly prob related to:
|
@jywarren There are a number of issues (this, this and many more) regarding this particular package all over the internet (including those over at the inline-md-editor). I mean, sure, we can continue to debug or wait for the devs at grunt to come up with something, or maybe, if you're still interested in that gulp/webpack idea, we can stop spending our time here and consider that instead. Both approaches are fine by me, but I was just concerned about the fact that this has stalled us for quite some time now, and would like to know your thoughts on the same. |
Hmmmm. I hear you. How much work would a Gulp refactor be? I worry if it's
a big lift.
…On Thu, Jan 24, 2019 at 9:24 PM Pranshu Srivastava ***@***.***> wrote:
@jywarren <https://github.com/jywarren> There are a number of issues (this
<gruntjs/grunt-contrib-jasmine#295>, this
<gruntjs/grunt-contrib-jasmine#266> and many
more) regarding this particular package all over the internet (not to
mention those over at the inline-md-editor
<publiclab/inline-markdown-editor#29>). I mean,
sure, we can continue to debug or wait for the devs at grunt to come up
with something, or maybe, if you're still interested in that gulp idea, we
can stop spending our time here and consider that instead.
Both approaches are fine by me, but I was just concerned about the fact
that this has stalled us for quite some time now, and would like to know
your thoughts on the same.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#168 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0kZTHO_9SARMKCavWGS8REO5JZ4ks5vGmq_gaJpZM4ZFi_f>
.
|
A newer version of grunt-contrib-jasmine exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps grunt-contrib-jasmine from 1.0.3 to 2.0.3.
Changelog
Sourced from grunt-contrib-jasmine's changelog.
Commits
201bb2a
Release v2.0.39b18221
Upgrade npm dependenciesd0e2572
fix: build only should pass if the buildSpecrunner runs without error74855ed
Update dependenciesd65dd20
v2.0.2d7f652f
Fix typo55a5f1f
Wait for spec runner before larunching browser408a233
Set the startTime before calling sendMessagea30f731
Create new optional 'noSandbox' option to launching Puppeteer with no-sandbox...a88f31b
Launching Puppeteer with no-sandbox arg.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge@dependabot reopen
will reopen this PR if it is closed@dependabot ignore this [patch|minor|major] version
will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.