Artillery 2.x compatibility #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've added further changes to get the same metrics as with Artillery's native Socket.io engine. |
| @@ -160,8 +161,8 @@ SocketIoEngine.prototype.step = function (requestSpec, ee) { | |||
| let delegateFunc = self.httpDelegate.step(requestSpec, ee); | |||
| return delegateFunc(context, callback); | |||
| } | |||
| ee.emit('counter', 'engine.socketio.emit', 1); | |||
| ee.emit('rate', 'engine.socketio.emit_rate'); | |||
| ee.emit('counter', 'socketio.emit', 1); | |||
There was a problem hiding this comment.
what is the rationale for this change? is this a broader artillery 2.0 change or?
There was a problem hiding this comment.
Yes, I've adapted the way metrics are tracked from artillery 2.0 (see https://github.com/artilleryio/artillery/blob/main/packages/core/lib/engine_socketio.js) so they will show up properly in reports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also needed the HTTP response times of HTTP requests embedded in socket.io scenarios, as the issue that referenced #13, so I thought I'd have a look at what it would mean to improve the Artillery 2.x compatibility. Seems like upgrading the dependency and changing the imports in the plug-in is all that's required to get it running with the new version.
There are probably more changes required to make use of new features in 2.x, but our existing test run as before, but now with the benefit of HTTP response times in the reports.