Add https support to apache2 on ICF-CI #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-monch
force-pushed
the
enh-ci-https
branch
9 times, most recently
from
ff22b36 to
840ced5
Compare
mih
added a commit
that referenced
this pull request
May 31, 2023
Won't be fixed before #22 has landed
|
The remaining errors are not related to https (datalad get fails) |
This commit updates the server keys to carry the FQDN in CN and subjectAltName
christian-monch
force-pushed
the
enh-ci-https
branch
from
04964ee to
62bcbfd
Compare
christian-monch
force-pushed
the
enh-ci-https
branch
from
1de95cd to
97ffe0e
Compare
christian-monch
force-pushed
the
enh-ci-https
branch
from
45ab5d6 to
134172f
Compare
Rename ChristianMoenchCA.crt to INM-ICF-TestCA.crt Clone this branch when building a singularity container. This should be removed, once the certificates are in main-branch
christian-monch
force-pushed
the
enh-ci-https
branch
from
568e4c3 to
ffa982d
Compare
christian-monch
force-pushed
the
enh-ci-https
branch
from
ffa982d to
2732615
Compare
|
Remaining get-errors where fixed by merging the latest changes from main into the branch. |
christian-monch
force-pushed
the
enh-ci-https
branch
from
086d218 to
fe31335
Compare
ste-phi
pushed a commit
to Aswendt-Lab/inm-icf-utilities
that referenced
this pull request
Sep 10, 2024
Won't be fixed before psychoinformatics-de#22 has landed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables SSL on the test-HTTP server. It installs all necessary certificates to enable
requestsandgit-annexto establish connections to the server.The PR changes the
data_webserver-fixture to return anhttps:-URL on an appveyor-VM. So all tests should run against an https:-endpoint.Fixes #17
BEFORE this PR can be merged, the following tasks have to be completed:
./singularity/icf.def:27according to the comment after Add certs for a test https server #36 was merged..appveyor/datafrom this branch (optional)To indicate that the previous tasks should be completed before the merge, this PR is put into draft mode