Major update of the things schema
#182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mih
force-pushed
the
towards-v1
branch
3 times, most recently
from
02da26a to
625cb3e
Compare
This is largely a rewrite aiming to orthogonalize schema elements and capture description needs more systematically. The new setup distinguished 'things' from 'attributes' (only the former requiring an identifier, and enabling the inline declaration of other 'things'). All slots that can be expressed with the basic schema mechanisms `is_characterized_by` and `has_attributes` -- for declaring qualified relationships -- have been removed. The only exception are basic RDF-related slots like (`predicate`, `object`, `range`, `value`, ...). The `relation` slots as means for inline declaration of things in the record of another `Thing` is preserved as a key schema feature. Likewise, the previous `meta_type` is kept under the new name `schema_type`. The new name better delineates this `rdf:type` variant from `type`, being a type designator slot for _schema_ classes. None of the derived schemas have been adjusted yet.
This is primarily in response to the `thing` revision. Additionally, the `Parameter` concept and the conflict of `AttributeSpecification` with its required `predicate` vs `has_parameter` needs another pass. The support for it has been removed here, and needs to be reintroduced once a suitable solution is available. This pending update should happen with awareness of #172
These are outdated and require an overhaul. However, this requires a reintroduction of a number of slot definitions that have been removed from `Thing`. Overall, it would be beneficial to rethink the purpose of `sdd`. It may be best seen as an example schema that could be used to craft concrete implementations along its patterns.
jsheunis
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
I spent an hour going through the detail of these commits. I got the general idea, but I don't think this was enough for me to get an intuitive grasp of the possibilities that the new Thing schema would allow. I like the simplicity of adding arbitrary attributes or characterizations at the level of triples, and how well values can be specified, even though I don't yet fully understand the interplay of the underlying classes and mixins.
I have not yet created a derived schema and exported it to shacl in order to see what it would look like or how a shacl-vue form would look like. That would be my next step. But IMO this PR can and should be merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a rewrite aiming to orthogonalize schema elements and capture description needs more systematically.
The new setup distinguished 'things' from 'attributes' (only the former requiring an identifier, and enabling the inline declaration of other 'things').
All slots that can be expressed with the basic schema mechanisms
is_characterized_byandhas_attributes-- for declaring qualified relationships -- have been removed. The only exception are basic RDF-related slots like (predicate,object,range,value, ...).The
relationslots as means for inline declaration of things in the record of anotherThingis preserved as a key schema feature. Likewise, the previousmeta_typeis kept under the new nameschema_type. The new name better delineates thisrdf:typevariant fromtype, being a type designator slot for schema classes.None of the derived schemas have been adjusted yet.
rdf:typevsdlthing:meta_typein the context of LinkML type designation #176 (bothtypeandschema_typenow map tordf:type, documentation clarifies the different/additive scopes)thingcan capture any information, so any additional slots only need to be define to capture information in preferred ways or with particualr validation, this makes the problem itself go away)