TASK: remove plow-js and refactor build stack #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markusguenther
force-pushed
the
task/remove-plow-js
branch
from
d7c2748 to
b01b63e
Compare
As we are able to resize the left sidebar nowadays we need to adjust the size and ellipsis handling.
|
@markusguenther Thanks for this work! Does this change anything related to Neos dependencies? |
|
Thanks @lorenzulrich as we have transpiled assets, we can use the package also with older Neos Instances. I tried it with Neos 7.3 and Neos 8.0 and it works. But when you want to name it 1.0 I am also fine with that :) flatnav-neos73.1.mp4 |
|
Maybe found a bug with scrolling in div containers. 🙈 |
@markusguenther What's the status on this? Is there a bug or not? If not, I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we changed the build stack in the Neos-UI to esbuild we are able to use the optional chaining (?.) operator in JavaScript. As the modern JavaScript is pretty powerful, we don’t need the helper methods from the plow-js library anymore.
The newer Neos versions also have the new feature to resize the left bar with the content and document tree. So the flatnav containers should also be resizable. This PR removes plow-js and therefore we get rid of the error messages in the console. We also use now esbuild with CSS modules to build the module assets.
With this change, we also lower the external dependencies.