Remove ENV_PATH on Black action completion. #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
reviewed
Jul 17, 2023
action/main.py
Outdated
| @@ -73,5 +74,6 @@ | |||
| stderr=STDOUT, | |||
| encoding="utf-8", | |||
| ) | |||
| shutil.rmtree(ENV_PATH) | |||
There was a problem hiding this comment.
Is it worth passing ignore_errors=True to this call? An error is unlikely, but it also shouldn't fail the entire action IMO.
There was a problem hiding this comment.
I agree, I think an error is unlikely but yeah shouldn't fail the entire action.
|
Don't mind the PyPy failures, it seems like a recent PyYAML release broke things on PyPy... :/ |
|
@ichard26 I've added a changelog entry and the |
hauntsaninja
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #3708 by deleting the
.black.envfolder specified byENV_PATHon action completion.I had a difficult time replicating the issue above @JelleZijlstra and I can't see that any changes were made to stable that would effect this behaviour. Probably worth deleting that
.black.envdir anyway?Checklist - did you ...
CHANGES.mdif necessary?