Re-organize the content of the *.proto files.
#14755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of the `*.proto` files is sorted by hard fork, then with a top-down fashion. Sorting first by hard fork lets the reader to easily see new or modified fields. Then, sorting with a top-down fashion lets the user to first see the big picture, then to dive into details. Also, the `new in <hard fork>` mentions are only written for the given hard fork. Thus, it'll avoid in the future the majority of the fields, not initially present in phase 0, to have the `new in <hard fork> mention`. This commit does not bring any new functional change.
nalepae
force-pushed
the
re-org-proto-content
branch
from
c89ac31 to
4c7b4e0
Compare
nalepae
changed the title
*.proto files.*.proto files.
terencechain
previously approved these changes
Dec 29, 2024
rkapka
reviewed
Dec 30, 2024
|
|
||
| // 96 byte BLS aggregate signature signed by the aggregator over the message. | ||
| bytes signature = 2 [(ethereum.eth.ext.ssz_size) = "96"]; | ||
| message SingleAttestation { |
Co-authored-by: Radosław Kapka <[email protected]>
Co-authored-by: Radosław Kapka <[email protected]>
rkapka
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The PR re-organizes the content of the
*.protofiles.The content of the
*.protofiles is sorted by hard fork, then with a top-down fashion.Sorting first by hard fork lets the reader to easily see new or modified fields. Then, sorting with a top-down fashion lets the user to first see the big picture, then to dive into details.
Also, the
new in <hard fork>mentions are only written for the given hard fork. Thus, it'll avoid in the future the majority of the fields, not initially present in phase 0, to have thenew in <hard fork> mention.This commit does not bring any new functional change.
Other notes for review
If the proposed organisation does not suit you, I have no objection at all to change it.
My main concern is to have something consistent in the same file and across the files.
The diff is quite large, but is actually mostly due to the re-organization of generated files due to the re-organization of the
*.protofiles.Acknowledgements