Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light client: add better error handling #14749

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

rupam-04
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

It improves how we handle errors in a few scenarios:

  • debug log instead of error log when finalized block is nil (nil block is expected at the beginning after checkpoint syncing)
  • debug log instead of error log when there are too little sync committee bits set (it's not a Prysm error when there is too little participation)
  • add block roots to logs for debugging purposes

Which issues(s) does this PR fix?

part of #12991

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@rupam-04 rupam-04 requested a review from a team as a code owner December 23, 2024 17:06
@rkapka rkapka enabled auto-merge December 26, 2024 20:24
@rkapka
Copy link
Contributor

rkapka commented Dec 26, 2024

[diff]

@rkapka rkapka added this pull request to the merge queue Dec 26, 2024
Merged via the queue into prysmaticlabs:develop with commit 9e7c1d6 Dec 26, 2024
15 checks passed
@rupam-04 rupam-04 deleted the error-handling branch December 26, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants