Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CU-86b2gwt48_PW-2040: Update IBAN (BBAN) validation data to July 2024 release #212

Merged
merged 3 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Prowide Core - CHANGELOG

#### 9.4.19 - SNAPSHOT
* (PW-2040) Updated the BBAN validation data file to the IBAN REGISTRY Jul 2024 release
* Added new `MtSequenceEnum` with all the available inner sequences of specific MT schemas

#### 9.4.18 - October 2024
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public enum IbanValidationResult {
INVALID_CHARACTERS("Invalid character '${found}' found"),
MISSING_CHECK_DIGITS("Missing check digits"),
INVALID_CHECK_DIGITS_FORMAT("Expected 2 check digits and found ${found}"),
IVALID_CHECK_DIGITS("The expected computed check digit is ${expectedCheckDigit} and ${found} was found"),
INVALID_CHECK_DIGITS("The expected computed check digit is ${expectedCheckDigit} and ${found} was found"),

MISSING_BBAN("Missing custom account number (BBAN)"),
BBAN_MAX_LENGTH(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ static IbanValidationResult validateCheckDigit(final String iban) {
if (calculateMod(iban) != 1) {
final String checkDigit = IBAN.getCheckDigits(iban);
final String expectedCheckDigit = calculateCheckDigit(iban);
IbanValidationResult result = IbanValidationResult.IVALID_CHECK_DIGITS;
IbanValidationResult result = IbanValidationResult.INVALID_CHECK_DIGITS;
result.setExpectedCheckDigit(expectedCheckDigit);
result.setFound(checkDigit);
return result;
zubri marked this conversation as resolved.
Show resolved Hide resolved
Expand Down
Loading
Loading