CU-86b11jgdc_PW-1913--IBAN-Validation--Request-for-Information #191
Conversation
WalkthroughWalkthroughIn version 9.4.17 of Prowide Core, IBAN validation support for Egypt was added. This includes new validation rules for the structure of Egyptian IBANs, modifications to existing validation classes, and updated test cases to ensure the IBANs are correctly validated. Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (3)
Additional context usedLanguageTool
Markdownlint
Additional comments not posted (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
CHANGELOG.md
Outdated
| #### 9.4.16 - May 2024 | ||
| * (PW-1913) Added IBAN validation for Egypt | ||
|
|
There was a problem hiding this comment.
Consolidate duplicate version entries and correct Markdown formatting.
The version 9.4.16 is listed twice with different entries. These should be consolidated into a single section. Additionally, correct the heading levels and list indentations to adhere to Markdown best practices.
- #### 9.4.16 - May 2024
- * (PW-1913) Added IBAN validation for Egypt
-
- #### 9.4.16 - May 2024
+ ### 9.4.16 - May 2024
+ - (PW-1913) Added IBAN validation for Egypt
+ - (PW-1862) Added NarrativeFragment class for detailed line information in StructuredNarrative fragments
+ - Fixed SwiftMessage getPDE(): return empty value instead of null when codeword exists and has no valueAlso applies to: 6-8
Tools
LanguageTool
[typographical] ~3-~3: If you want to indicate numerical ranges or time ranges, consider using an en dash.
Context: # Prowide Core - CHANGELOG #### 9.4.16 - May 2024 * (PW-1913) Added IBAN valida...(DASH_RULE)
Markdownlint
3-3: Expected: h2; Actual: h4
Heading levels should only increment by one level at a time(MD001, heading-increment)
4-4: Expected: 0; Actual: 2
Unordered list indentation(MD007, ul-indent)
3-3: Expected: 1; Actual: 0; Below
Headings should be surrounded by blank lines(MD022, blanks-around-headings)
4-4: null
Lists should be surrounded by blank lines(MD032, blanks-around-lists)
ptorres-prowide
force-pushed
the
CU-86b11jgdc_PW-1913--IBAN-Validation--Request-for-Information
branch
from
d8034df to
d137ad8
Compare
zubri
deleted the
CU-86b11jgdc_PW-1913--IBAN-Validation--Request-for-Information
branch
Summary by CodeRabbit
New Features
Tests