CU-86b2gwt48_PW-2040--IBAN-validation-problem

prowide · Nov 15, 2024 · 8fb2a67 · 8fb2a67
1 parent 69557a4
commit 8fb2a67
Show file tree

Hide file tree

Showing 6 changed files with 608 additions and 234 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Prowide Core - CHANGELOG
 
+#### 9.4.19 - SNAPSHOT
+  * (PW-2040) Added IBAN validation for the 88 supported countries 
+
 #### 9.4.18 - October 2024
   * Added new `FieldEnum` with all the available field names
   * Code security improvements as per CodeQL recommendations

diff --git a/src/main/java/com/prowidesoftware/swift/model/IbanValidationResult.java b/src/main/java/com/prowidesoftware/swift/model/IbanValidationResult.java
@@ -42,7 +42,7 @@ public enum IbanValidationResult {
     INVALID_CHARACTERS("Invalid character '${found}' found"),
     MISSING_CHECK_DIGITS("Missing check digits"),
     INVALID_CHECK_DIGITS_FORMAT("Expected 2 check digits and found ${found}"),
-    IVALID_CHECK_DIGITS("The expected computed check digit is ${expectedCheckDigit} and ${found} was found"),
+    INVALID_CHECK_DIGITS("The expected computed check digit is ${expectedCheckDigit} and ${found} was found"),
 
     MISSING_BBAN("Missing custom account number (BBAN)"),
     BBAN_MAX_LENGTH(

diff --git a/src/main/java/com/prowidesoftware/swift/model/IbanValidationUtils.java b/src/main/java/com/prowidesoftware/swift/model/IbanValidationUtils.java
@@ -214,7 +214,7 @@ static IbanValidationResult validateCheckDigit(final String iban) {
         if (calculateMod(iban) != 1) {
             final String checkDigit = IBAN.getCheckDigits(iban);
             final String expectedCheckDigit = calculateCheckDigit(iban);
-            IbanValidationResult result = IbanValidationResult.IVALID_CHECK_DIGITS;
+            IbanValidationResult result = IbanValidationResult.INVALID_CHECK_DIGITS;
             result.setExpectedCheckDigit(expectedCheckDigit);
             result.setFound(checkDigit);
             return result;