Adjust lifetimes on ModelIter
to make them more permissive
#324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, iterating over a Model creates
FuncDecls
that reference the lifetime of the reference of the model that they come from, rather than the lifetime of context it contains.This means that it is impossible to use those
FuncDecls
after the model is dropped, even when the context is still around. From looking at the code, this just seems like a bug, but let me know if this is intentional.This PR adjusts the lifetimes of
ModelIter
to also explicitly include the lifetime of the model reference. This way it can returnFuncDecl
that properly reference the lifetime of the context.