is_const_array and Distinct with &[impl Borrow<Self>]

[Pat-Lafon]

• Distinct currently takes &[&Self] for which I would like to do a similar api relaxing like in Use Borrow in varop arrays #246.
• With the new Rust version, there is a minor clippy change.
• Python has this nice is_const_array(a) function which I would like to propose here.

[waywardmonkeys]

Is this correct?

[Pat-Lafon]

That is coming from

z3.rs/z3-sys/src/lib.rs

Lines 520 to 522 in 3c97663

	/// The constant array. For example, `select(const(v),i) = v`
	/// holds for every `v` and `i`. The function is unary.
	CONST_ARRAY = generated::Z3_decl_kind::Z3_OP_CONST_ARRAY as u32,

. So I believe so? Maybe only a single implication now that I think of it because I'm not sure if a nested store gets collapsed. (store (store ((as const (Array Int Int)) 9) 0 1281) 0 9)

[Pat-Lafon]

If that was your concerned, I changed that comment

[waywardmonkeys]

Sorry, I had commented while doing something else and from my phone away from home.

My concern was actually about the formatting and if that should be in the summary line at the top of the comment.

Should also have a blank line before the example header.

[waywardmonkeys]

Could you squash the various commits for is_const_array into a single commit? After removing the clippy fix (already on master), that would leave one commit for the Distinct change and one for is_const_array.

[waywardmonkeys]

Thanks!