-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use system-shipped z3 libraries by pkg_config #248
Conversation
There is also now #249 which differs some from this ... |
It’s totally different because it will use dynamic libraries from distributions like homebrew, Debian etc. In other words, the two PRs are not conflicting regarding features offered. |
Okay, so now we have |
I can't understand how |
Can confirm this works on fedora without manually setting the environment variable! |
@waywardmonkeys The problem is that bindgen is not finding the header files when it should be because the include path is not set up correctly. Most linux distributions use pkg-config to specify C library metadata such as include path, linker flags etc. |
I've fixed the merge conflict, here is a patch: resolve-conflict.patch |
I will get this landed later today when I am back home. |
politely pings @waywardmonkeys |
I've done a fresh update of this PR in #277 and will land it once it passes CI. Thanks for the initial work! |
Probably a bit more elegant way to use precompiled binaries compared to #193 by utilizing
pkg-config
, which is ubiquitous of all *nix platforms.My usecase is to use homebrew installed z3 library.
Changes:
pkg_config
z3/src/api/z3.h
, use the universalz3.h
with corresponding include directories added, which should be a more general approach.No break changes are introduced in theory and should be safe to go.