WIP: feat(table): enhancements for table action system #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dataSource references
saithis
reviewed
Jul 1, 2021
| @@ -13,7 +16,7 @@ const MAX_SAFE_INTEGER = 9007199254740991; | |||
| export interface PsTableDataSourceOptions<TData, TTrigger = any> { | |||
| loadTrigger$?: Observable<TTrigger>; | |||
| loadDataFn: (updateInfo: IExtendedPsTableUpdateDataInfo<TTrigger>) => Observable<TData[] | IPsTableFilterResult<TData>>; | |||
| actions?: IPsTableAction<TData>[]; | |||
| actions?: IPsTableAction<TData>[] | Observable<IPsTableAction<TData>[]>; | |||
There was a problem hiding this comment.
not a fan of this, this increases complexity and code size quite a bit
| <mat-icon [style.color]="action.iconColor">{{ action.icon }}</mat-icon> | ||
| {{ action.label }} | ||
| </button> | ||
| <ng-container *ngIf="action.isLoading || !action.hasChildren; else branch"> |
There was a problem hiding this comment.
the changes here could have a substantial performance impact. all that s ifs and templates are the reason for the current performance problems. with this we have even more of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #177