Skip to content

Commit

Permalink
chore: fix warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
valeriansaliou committed Oct 17, 2023
1 parent fe56a8a commit 159078a
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 16 deletions.
6 changes: 3 additions & 3 deletions src/broker/delegate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class BrokerDelegate implements ProseClientDelegate {
this.__eventBus.emit("client:disconnected");
}

async composingUsersChanged(client: ProseClient, room: Room): Promise<void> {
async composingUsersChanged(_client: ProseClient, room: Room): Promise<void> {
const composingUsers = await room.loadComposingUsers();

logger.info(
Expand All @@ -63,7 +63,7 @@ class BrokerDelegate implements ProseClientDelegate {
// TODO: Handle multiple composing users in the UI
}

roomsChanged(_client: ProseClient): void {
roomsChanged(): void {
Store.$muc.markRoomsChanged();
Store.$muc.load();
}
Expand Down Expand Up @@ -114,7 +114,7 @@ class BrokerDelegate implements ProseClientDelegate {
}

async messagesUpdated(
client: ProseClient,
_client: ProseClient,
room: Room,
messageIDs: string[]
): Promise<void> {
Expand Down
20 changes: 10 additions & 10 deletions src/components/base/BaseAlert.vue
Original file line number Diff line number Diff line change
Expand Up @@ -140,16 +140,6 @@ export default {
});
},

created() {
// Bind show event
EventBus.on("show", this.show as Handler);
},

beforeUnmount() {
// Unbind show event
EventBus.off("show", this.show as Handler);
},

computed: {
badgeIcon(): string {
switch (this.level) {
Expand All @@ -173,6 +163,16 @@ export default {
}
},

created() {
// Bind show event
EventBus.on("show", this.show as Handler);
},

beforeUnmount() {
// Unbind show event
EventBus.off("show", this.show as Handler);
},

methods: {
show({
level,
Expand Down
7 changes: 5 additions & 2 deletions src/components/inbox/InboxMessaging.vue
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,11 @@ import {
Platform as MessagingPlatform,
Messaging as MessagingRuntime,
SeekDirection as MessagingSeekDirection,
Theme as MessagingTheme
Theme as MessagingTheme,
EventMessageActionsView,
EventMessageReactionsView,
EventMessageReactionsReact,
EventMessageHistorySeek
} from "@prose-im/prose-core-views/types/messaging";

// PROJECT: STYLES
Expand Down Expand Up @@ -1129,7 +1133,6 @@ $c: ".c-inbox-messaging";
justify-content: center;
position: absolute;
inset: 0;
z-index: 2;
}

#{$c}__popover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ export default {
methods: {
// --> EVENT LISTENERS <--

onDataTableControlClick(type: DataTableControlType): void {
onDataTableControlClick(): void {
// TODO: handle action for type
}
}
Expand Down

0 comments on commit 159078a

Please sign in to comment.