[generic issuance] pipeline CRUD app with minimal UI #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robknight
reviewed
Jan 31, 2024
| return pipeline; | ||
| } | ||
|
|
||
| public async upsertPipelineDefinition( |
There was a problem hiding this comment.
One thing this doesn't do is cause the generic issuance server to actually load the pipeline. It gets stored in this.definitionDB, but this.pipelines doesn't have the pipeline in it until this.createPipelines() is called. Possibly we want something like reloadPipeline(pipelineId) for when a pipeline has changed.
There was a problem hiding this comment.
Discussed over call - will integrate this later today once items like #1452 have been merged
ichub
approved these changes
Jan 31, 2024
apps/passport-server/src/services/generic-issuance/genericIssuanceService.ts
Show resolved
Hide resolved
| return pipeline; | ||
| } | ||
|
|
||
| public async upsertPipelineDefinition( |
apps/passport-server/src/services/generic-issuance/genericIssuanceService.ts
Show resolved
Hide resolved
apps/passport-server/src/services/generic-issuance/genericIssuanceService.ts
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
This backs the `PipelineDefinitionDB` on to the Postgres DB. It's quite crude and is also missing user-management features, but it works for being able to start pipelines outside of tests. I've avoided doing user-management code since that overlaps with #1451
robknight
reviewed
Feb 1, 2024
robknight
reviewed
Feb 1, 2024
packages/lib/passport-interface/src/api/requestGenericIssuanceGetAllUserPipelines.ts
Show resolved
Hide resolved
robknight
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1428
TODO
What's in here:
What's not in here:
Screen.Recording.2024-01-31.at.5.04.26.AM.mov