Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the instance label to NodeHighNumberConntrackEntriesUsed alert description #3202

Merged

Conversation

daviderli614
Copy link
Contributor

@daviderli614 daviderli614 commented Dec 11, 2024

The description of other alerts has the instance label, but the NodeHighNumberConntrackEntriesUsed alert does not have it.

@daviderli614 daviderli614 force-pushed the chore/add-instance-label branch from 9f54324 to 1a0f88b Compare December 11, 2024 03:42
@daviderli614
Copy link
Contributor Author

daviderli614 commented Dec 13, 2024

Can help review it? Thanks
@discordianfish @SuperQ

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@discordianfish discordianfish merged commit 505363a into prometheus:master Dec 23, 2024
7 checks passed
@daviderli614 daviderli614 deleted the chore/add-instance-label branch December 23, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants