-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diskstats): add metric for bare disk capacity #3068
Draft
fs185143
wants to merge
13
commits into
prometheus:master
Choose a base branch
from
fs185143:disk-capacity-metric
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a939e51
foundational logic for linux disk capacity metric
fs185143 672a9cf
using ghw for disk size
fs185143 6006706
moved disk size update out of loop
fs185143 2f203b4
updated diskstats test
fs185143 fcbe324
removed unused variable
fs185143 3f5296d
updated deps
fs185143 58b2f9c
updated to use new incoming procfs function
fs185143 7788877
updated deps
fs185143 fa915d7
continue if err
fs185143 d2ecfa7
returned whitespace
fs185143 6a188ae
disk -> device
fs185143 d8e74d6
updated with new incoming SysBlockDeviceSizeBytes
fs185143 3bf7c9b
Merge branch 'master' into disk-capacity-metric
fs185143 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote in prometheus/procfs#650 (comment), this will be incorrect for Advanced Format (AF / 4K sector) drives, since
/sys/block/<dev>/size
, which your proposedSysBlockDeviceSize
method returns, is always reported in units of 512-byte sectors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated that PR, as well as this one to use the new method
d8e74d6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
happy with the change? wondering if we can try get these PRs moving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but obviously this is contingent on the procfs PR being accepted first.