Fix: Add safety check to hwmon read

Avoid panic for accessing slice out of range in hwmon. Fixes: #3108 Signed-off-by: Ben Kochie <[email protected]>
prometheus · Sep 30, 2024 · 1b332ed · 1b332ed
1 parent ebf3cbf
commit 1b332ed
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/collector/hwmon_linux.go b/collector/hwmon_linux.go
@@ -18,6 +18,7 @@ package collector
 
 import (
 	"errors"
+	"fmt"
 	"log/slog"
 	"os"
 	"path/filepath"
@@ -107,6 +108,9 @@ func sysReadFile(file string) ([]byte, error) {
 	if err != nil {
 		return nil, err
 	}
+	if n < 0 {
+		return nil, fmt.Errorf("failed to read file: %q, read returned negative bytes value: %d", file, n)
+	}
 
 	return b[:n], nil
 }