Fix error metrics for APIGateway example #1538
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/apigw.yml
Outdated
| statistics: [Sum] | ||
| - name: 5xx | ||
| - name: 5XXError |
There was a problem hiding this comment.
@vasyharan I think 4xx and 5xx are valid metrics for APIGateway v1 (http), while 4XXError and 5XXError are for APIGateway v2 (rest). Maybe we should have two example files?
There was a problem hiding this comment.
I didn't realize that these were different versions! Updated to add a new files for v2.
cristiangreco
requested changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the APIGateway example with the correct names for error metrics