Implement new concurrency limit mechanism for the CloudWatch client #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // perAPICallLimiter is a ConcurrencyLimiter that keeps a different concurrency limiter per different API call. This allows | ||
| // a more granular control of concurrency, allowing us to take advantage of different api limits. For example, ListMetrics | ||
| // has a limit of 25 TPS, while GetMetricData has none. | ||
| type perAPICallLimiter map[string]chan struct{} |
There was a problem hiding this comment.
Could we potentially use three different singleLimiter instead of the perAPICallLimiter? I think that would be a bit more readable perhaps?
There was a problem hiding this comment.
ok so extracted the common funcionality into a simple semaphore type, and re-used that everywhere.
thepalbi
force-pushed
the
pablo/new-concurrency-limiter
branch
from
1578282 to
d551711
Compare
|
@cristiangreco what do you think of the latest changes here? |
cristiangreco
approved these changes
Sep 27, 2023
Co-authored-by: Cristian Greco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a new concurrency mechanism for the CloudWatch client. For this, the client is decoupled of how the concurrency is limited, and two implementations are provided:
The second one will allow us to take full advantage of the rate limits imposed by AWS into each api.