feat: Tolerate collector failures

Signed-off-by: Jan-Otto Kröpke <[email protected]>
prometheus-community · Nov 25, 2024 · f3cdb48 · f3cdb48
1 parent 532568a
commit f3cdb48
Show file tree

Hide file tree

Showing 14 changed files with 21 additions and 2 deletions.
diff --git a/internal/collector/diskdrive/diskdrive.go b/internal/collector/diskdrive/diskdrive.go
@@ -139,6 +139,7 @@ type diskDrive struct {
 	Availability uint16 `mi:"Availability"`
 }
 
+//nolint:gochecknoglobals
 var (
 	allDiskStatus = []string{
 		"OK",

diff --git a/internal/collector/iis/iis_app_pool_was.go b/internal/collector/iis/iis_app_pool_was.go
@@ -57,6 +57,7 @@ const (
 	TotalWorkerProcessStartupFailures  = "Total Worker Process Startup Failures"
 )
 
+//nolint:gochecknoglobals
 var applicationStates = map[uint32]string{
 	1: "Uninitialized",
 	2: "Initialized",

diff --git a/internal/collector/printer/printer.go b/internal/collector/printer/printer.go
@@ -31,6 +31,8 @@ import (
 const Name = "printer"
 
 // printerStatusMap source: https://learn.microsoft.com/en-us/windows/win32/cimwin32prov/win32-printer#:~:text=Power%20Save-,PrinterStatus,Offline%20(7),-PrintJobDataType
+//
+//nolint:gochecknoglobals
 var printerStatusMap = map[uint16]string{
 	1: "Other",
 	2: "Unknown",

diff --git a/internal/collector/textfile/textfile_test_test.go b/internal/collector/textfile/textfile_test_test.go
@@ -29,6 +29,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
+//nolint:gochecknoglobals
 var baseDir = "../../../tools/textfile-test"
 
 //nolint:paralleltest

diff --git a/internal/headers/iphlpapi/iphlpapi.go b/internal/headers/iphlpapi/iphlpapi.go
@@ -23,6 +23,7 @@ import (
 	"golang.org/x/sys/windows"
 )
 
+//nolint:gochecknoglobals
 var (
 	modiphlpapi             = windows.NewLazySystemDLL("iphlpapi.dll")
 	procGetExtendedTcpTable = modiphlpapi.NewProc("GetExtendedTcpTable")

diff --git a/internal/headers/kernel32/kernel32.go b/internal/headers/kernel32/kernel32.go
@@ -21,6 +21,7 @@ import (
 	"golang.org/x/sys/windows"
 )
 
+//nolint:gochecknoglobals
 var (
 	kernel32 = windows.NewLazySystemDLL("kernel32.dll")
 

diff --git a/internal/headers/netapi32/netapi32.go b/internal/headers/netapi32/netapi32.go
@@ -45,6 +45,7 @@ type WorkstationInfo struct {
 	LoggedOnUsers uint32
 }
 
+//nolint:gochecknoglobals
 var (
 	netapi32             = windows.NewLazySystemDLL("netapi32")
 	procNetWkstaGetInfo  = netapi32.NewProc("NetWkstaGetInfo")
@@ -53,6 +54,8 @@ var (
 
 // NetApiStatus is a map of Network Management Error Codes.
 // https://docs.microsoft.com/en-gb/windows/win32/netmgmt/network-management-error-codes?redirectedfrom=MSDN
+//
+//nolint:gochecknoglobals
 var NetApiStatus = map[uint32]string{
 	// Success
 	0: "NERR_Success",

diff --git a/internal/headers/psapi/psapi.go b/internal/headers/psapi/psapi.go
@@ -40,6 +40,7 @@ type PerformanceInformation struct {
 	ThreadCount       uint32
 }
 
+//nolint:gochecknoglobals
 var (
 	psapi                  = windows.NewLazySystemDLL("psapi.dll")
 	procGetPerformanceInfo = psapi.NewProc("GetPerformanceInfo")

diff --git a/internal/headers/secur32/secur32.go b/internal/headers/secur32/secur32.go
@@ -25,7 +25,8 @@ import (
 )
 
 // based on https://github.com/carlpett/winlsa/blob/master/winlsa.go
-
+//
+//nolint:gochecknoglobals
 var (
 	secur32  = windows.NewLazySystemDLL("Secur32.dll")
 	advapi32 = windows.NewLazySystemDLL("advapi32.dll")

diff --git a/internal/headers/slc/slc.go b/internal/headers/slc/slc.go
@@ -22,6 +22,7 @@ import (
 	"golang.org/x/sys/windows"
 )
 
+//nolint:gochecknoglobals
 var (
 	slc                         = windows.NewLazySystemDLL("slc.dll")
 	procSLIsWindowsGenuineLocal = slc.NewProc("SLIsWindowsGenuineLocal")

diff --git a/internal/headers/sysinfoapi/sysinfoapi.go b/internal/headers/sysinfoapi/sysinfoapi.go
@@ -113,6 +113,7 @@ const (
 	ComputerNameMax
 )
 
+//nolint:gochecknoglobals
 var (
 	kernel32                 = windows.NewLazySystemDLL("kernel32.dll")
 	procGetSystemInfo        = kernel32.NewProc("GetSystemInfo")

diff --git a/internal/headers/wtsapi32/wtsapi32.go b/internal/headers/wtsapi32/wtsapi32.go
@@ -97,6 +97,7 @@ type WTSSession struct {
 	FarmName    string
 }
 
+//nolint:gochecknoglobals
 var (
 	wtsapi32 = windows.NewLazySystemDLL("wtsapi32.dll")
 

diff --git a/internal/mi/application.go b/internal/mi/application.go
@@ -31,6 +31,7 @@ const (
 	LocaleEnglish = "en-us"
 )
 
+//nolint:gochecknoglobals
 var (
 	// DestinationOptionsTimeout is the key for the timeout option.
 	//

diff --git a/internal/mi/callbacks.go b/internal/mi/callbacks.go
@@ -27,7 +27,10 @@ import (
 	"golang.org/x/sys/windows"
 )
 
-// We have to registry a global callback function, since the amount of callbacks is limited.
+// operationUnmarshalCallbacksInstanceResult registers a global callback function.
+// The amount of system callbacks is limited to 2000.
+//
+//nolint:gochecknoglobals
 var operationUnmarshalCallbacksInstanceResult = sync.OnceValue[uintptr](func() uintptr {
 	// Workaround for a deadlock issue in go.
 	// Ref: https://github.com/golang/go/issues/55015
-Original file line number
+Diff line change
@@ Expand Up / @@ -139,6 +139,7 @@ type diskDrive struct { @@
     	Availability uint16 `mi:"Availability"`
     }
+    //nolint:gochecknoglobals
     var (
     	allDiskStatus = []string{
     		"OK",
@@ Expand Down @@