Add support for device types and predictable device paths (rebased) #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will now log a warning if smartctl path passed via command line is invalid. Signed-off-by: Piotr Dobrowolski <[email protected]> (cherry picked from commit 1c9c694)
This adds a new command line option allowing for customization of autodetected device types and enables use of special "by-id" device type that forces use of predictable device paths (/dev/disk/by-id/...) Relevant change to device name parsing regular expression is included now, so predictable device paths are now also usable when directly specified. Signed-off-by: Piotr Dobrowolski <[email protected]> (cherry picked from commit 4c5f721) Conflicts: - file: 'readjson.go' comment: 'manually resolve new logger issues'
Signed-off-by: Piotr Dobrowolski <[email protected]> (cherry picked from commit 319184c) Conflicts: - file: 'main.go' comment: 'manually resolve new logger issues' - file: 'readjson.go' comment: 'manually resolve new logger issues'
|
Compared diff with 0.12.0. No actual diff in produced metrics (as expected for upgrades), only for fixes 
|
robbat2
approved these changes
Dec 19, 2024
SuperQ
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
Closed
k0ste
added a commit
to k0ste/smartctl_exporter
that referenced
this pull request
Dec 19, 2024
* [CHANGE] `slog` used for logging instead go logger prometheus-community#246 * [ENHANCEMENT] Added support for `megaraid` devices and device types prometheus-community#205 prometheus-community#257 * [BUGFIX] Better support for smartmontools < 7.3 prometheus-community#238 * [BUGFIX] Corrected NVMe read/write bytes to NVMe metrics prometheus-community#211 Signed-off-by: Konstantin Shalygin <[email protected]>
Merged
SuperQ
pushed a commit
that referenced
this pull request
Dec 20, 2024
* [CHANGE] `slog` used for logging instead go logger #246 * [ENHANCEMENT] Added support for `megaraid` devices and device types #205 #257 * [BUGFIX] Better support for smartmontools < 7.3 #238 * [BUGFIX] Corrected NVMe read/write bytes to NVMe metrics #211 Signed-off-by: Konstantin Shalygin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems author in #235 downshifted to inactive. Rebased all this patches, fixed merge conflicts