feat: Better SCSI/SAS support, and removing confused metrics #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Query:
|
The exporter presently has metrics that are nonsense for a given type of drive, and remain at zero due to their defaults. Change the behavior to NOT emit a metric if the underlying JSON field is not present. Future related work may include parsing the corresponding metrics for SATA/SAS SSDs (e.g. `smartctl_device_percentage_used` could derived from `SSD_Life_Left` on some drives). Metrics no longer exported for the wrong type of drive: - `smartctl_device_nvme_capacity_bytes` (NVME-specific) - `smartctl_device_available_spare` (NVME-specific, ATA possible) - `smartctl_device_available_spare_threshold` (NVME-specific, ATA possible) - `smartctl_device_critical_warning` (NVME-specific, ATA possible) - `smartctl_device_interface_speed` (ATA-specific) - `smartctl_device_media_errors` (NVME-specific, ATA possible) - `smartctl_device_num_err_log_entries` (NVME-specific, SCSI uses distinct metrics, ATA possible) - `smartctl_device_nvme_capacity_bytes` (NVME-specific) - `smartctl_device_percentage_used` (NVME-specific, ATA possible) Signed-off-by: Robin H. Johnson <[email protected]>
Fix the following metrics that were exported as zero because the
exporter did not know how to read them for SCSI devices:
- smartctl_device_bytes_read
- smartctl_device_bytes_written
- smartctl_device_power_cycle_count
New metrics:
- smartctl_read_errors_corrected_by_eccdelayed
- smartctl_read_errors_corrected_by_eccfast
- smartctl_write_errors_corrected_by_eccdelayed
- smartctl_write_errors_corrected_by_eccfast
Fix labels:
- smartctl_device{model_name} is now populated for SCSI/SAS, using
scsi_model_name.
New labels:
- smartctl_device{} gains:
scsi_product,scsi_revision,scsi_vendor,scsi_version
Signed-off-by: Robin H. Johnson <[email protected]>
robbat2
force-pushed
the
rjohnson/scsi-support
branch
from
e32ad2a to
9113c6c
Compare
|
@SuperQ can you review and merge please? |
There isn't one but it would be nice to start building one. I don't have any SCSI/SAS devices so I can't really test this PR. Can you attach the |
|
@NiceGuyIT Can we consider a formal consistent script that redacts sensitive info in the JSON? Partial list: I've got 20+ models of drive over technologies & vendors from my personal access, counting before $job drives. |
|
#175 contains the test data suggestion. |
SuperQ
added a commit
that referenced
this pull request
Mar 3, 2024
* [CHANGE] Better SCSI/SAS support, and removing confused metrics #168 * [ENHANCEMENT] Impvoe the JSON collection script; now requires jq/yq #176 * [BUGFIX] Shell fixes for `collect-smartctl-json.sh` #178 * [BUGFIX] Various fixes to `collect_fake_json.sh` #159 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement better SCSI/SAS support, including less confused metrics.
The exporter, prior to this PR, exports a value of "0" for some metrics
that were specific to certain types of drives; these metrics will no
longer be exported for types where that metric is not valid. Future work
may include parsing the corresponding metrics for SATA/SAS SSDs.
Metrics no longer exported for the wrong type of drive:
possible)
metrics, ATA possible)
Fix the following metrics that were exported as zero because the
exporter did not know how to read them for SCSI devices:
New metrics:
Fix labels:
scsi_model_name.
New labels:
scsi_product,scsi_revision,scsi_vendor,scsi_version
Signed-off-by: Robin H. Johnson [email protected]