Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract drive temperature from storcli #188

Merged
merged 3 commits into from
Nov 23, 2023

Conversation

jValdron
Copy link
Contributor

Adds a new metric under megaraid for physical drives temperature. There's a Drive Temperature field under Drive $DRIVE State, at least for my controller (PERC H730).

storcli.py Outdated Show resolved Hide resolved
storcli.py Outdated Show resolved Hide resolved
@dswarbrick
Copy link
Member

Since this is a new metric (and possibly optional), can you move it to the end of list, after pd_emergency_spare? It seems kind of out of place currently, having landed smack in the middle of existing code.

Signed-off-by: Jason Valdron <[email protected]>
@jValdron
Copy link
Contributor Author

Since this is a new metric (and possibly optional), can you move it to the end of list, after pd_emergency_spare? It seems kind of out of place currently, having landed smack in the middle of existing code.

Sure thing, I had put it in the order of how it shows up in storcli output.

@dswarbrick dswarbrick merged commit 3018120 into prometheus-community:master Nov 23, 2023
4 checks passed
allamiro pushed a commit to allamiro/node-exporter-textfile-collector-scripts that referenced this pull request Nov 16, 2024
Expose physical drive temperature in degrees Celsius if available.

Signed-off-by: Jason Valdron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants