feat: add bmc url #219
Merged
feat: add bmc url #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyFX
force-pushed
the
feat--add-bmc-url
branch
from
3e492c4 to
2993a9a
Compare
|
Hello @bitfehler @SuperQ, can you take a look on my PR? |
bitfehler
requested changes
Dec 5, 2024
Signed-off-by: happyfx <[email protected]>
Signed-off-by: happyfx <[email protected]>
Signed-off-by: happyfx <[email protected]>
HappyFX
force-pushed
the
feat--add-bmc-url
branch
from
f153ce0 to
21518d8
Compare
HappyFX
added a commit
to HappyFX/ipmi_exporter
that referenced
this pull request
Dec 6, 2024
* feat: add bmc url Signed-off-by: happyfx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SuperQ Hi!
Please review the PR. I need to add URL info from BMC.
Actual output from console