Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kube-prometheus-stack]: bump to 0.79.0 #5060

Merged
merged 4 commits into from
Dec 15, 2024
Merged

[kube-prometheus-stack]: bump to 0.79.0 #5060

merged 4 commits into from
Dec 15, 2024

Conversation

KyriosGN0
Copy link
Contributor

Signed-off-by: AvivGuiser [email protected]

What this PR does / why we need it

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@KyriosGN0
bump chart version
c15c72e 
Signed-off-by: AvivGuiser <[email protected]>
@KyriosGN0
prometheus-operator-crds
100bf5d 
Signed-off-by: AvivGuiser <[email protected]>
@KyriosGN0
bump chart version itself
0f0787d 
Signed-off-by: AvivGuiser <[email protected]>
jkroepke
jkroepke approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No new RBAC permissions needed. LGTM

https://github.com/prometheus-operator/prometheus-operator/blame/main/example/rbac/prometheus-operator/prometheus-operator-cluster-role.yaml

jkroepke
jkroepke requested changes Dec 14, 2024
View reviewed changes
Copy link
Member

@jkroepke jkroepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, please regenerate the CRDs.

@KyriosGN0
update crds
fea6c68 
Signed-off-by: AvivGuiser <[email protected]>
@KyriosGN0
Copy link
Contributor Author

@jkroepke updated crds

@KyriosGN0 KyriosGN0 requested a review from jkroepke December 15, 2024 10:01
@jkroepke jkroepke merged commit ee6b446 into prometheus-community:main Dec 15, 2024
4 checks passed
@jkroepke
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkroepke jkroepke jkroepke approved these changes

@andrewgkew andrewgkew Awaiting requested review from andrewgkew andrewgkew is a code owner

@gianrubio gianrubio Awaiting requested review from gianrubio gianrubio is a code owner

@gkarthiks gkarthiks Awaiting requested review from gkarthiks gkarthiks is a code owner

@GMartinez-Sisti GMartinez-Sisti Awaiting requested review from GMartinez-Sisti GMartinez-Sisti is a code owner

@QuentinBisson QuentinBisson Awaiting requested review from QuentinBisson QuentinBisson is a code owner

@scottrigby scottrigby Awaiting requested review from scottrigby scottrigby is a code owner

@Xtigyro Xtigyro Awaiting requested review from Xtigyro Xtigyro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyriosGN0 @jkroepke