Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-state-metrics] fix: Default kube-state-metrics resources to empty #4619

Merged
merged 4 commits into from
Jun 23, 2024

Conversation

smcavallo
Copy link
Contributor

Signed-off-by: smcavallo [email protected]

What this PR does / why we need it

Writes the default of resources: {} instead of omitting. The current behavior causes tools like argocd to show a diff.
This is because if the field does not exist kubernetes will set the default.
image
There is already a default in values.yaml and the default is {} so there is no need to wrap in a conditional.

New behavior is:
helm template --values=values.yaml .

          initialDelaySeconds: 5
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 5
        resources:
          {}
        securityContext:
          allowPrivilegeEscalation: false
          capabilities:
            drop:
            - ALL
          readOnlyRootFilesystem: true

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

Checklist

  • [X ] DCO signed
  • [X ] Chart Version bumped
  • [X ] Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@dotdc dotdc merged commit efa4f84 into prometheus-community:main Jun 23, 2024
4 checks passed
@dotdc
Copy link
Member

dotdc commented Jun 23, 2024

Thank you for your contribution @smcavallo !

kireque referenced this pull request in kireque/home-ops Jun 24, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[kube-state-metrics](https://togithub.com/kubernetes/kube-state-metrics/)
([source](https://togithub.com/prometheus-community/helm-charts)) |
patch | `5.20.0` -> `5.20.1` |

---

### Release Notes

<details>
<summary>prometheus-community/helm-charts (kube-state-metrics)</summary>

###
[`v5.20.1`](https://togithub.com/prometheus-community/helm-charts/releases/tag/kube-state-metrics-5.20.1)

[Compare
Source](https://togithub.com/prometheus-community/helm-charts/compare/kube-state-metrics-5.20.0...kube-state-metrics-5.20.1)

Install kube-state-metrics to generate and expose cluster-level metrics

#### What's Changed

- \[kube-state-metrics] fix: Default kube-state-metrics resources to
empty by [@&#8203;smcavallo](https://togithub.com/smcavallo) in
[https://github.com/prometheus-community/helm-charts/pull/4619](https://togithub.com/prometheus-community/helm-charts/pull/4619)

**Full Changelog**:
prometheus-community/helm-charts@prometheus-fastly-exporter-0.4.0...kube-state-metrics-5.20.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTQuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQxNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9wYXRjaCJdfQ==-->

Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
@smcavallo smcavallo deleted the ksm-resources branch June 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants