[prometheus-statsd-exporter] Add DaemonSet option to statsd exporter and update helm chart options #4588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NabilusT
approved these changes
Jun 4, 2024
|
Hey @scDisorder could you give it a look? Thanks! |
…theus-community#4572) Signed-off-by: Thomas Way <[email protected]> Signed-off-by: Lukas Monkevicius <[email protected]>
…dependently configured (prometheus-community#4562) Signed-off-by: Kyle Brown <[email protected]> Signed-off-by: Lukas Monkevicius <[email protected]>
…heus operator (prometheus-community#4570) Signed-off-by: Lukas Monkevicius <[email protected]>
Signed-off-by: Lukas Monkevicius <[email protected]>
Signed-off-by: Lukas Monkevicius <[email protected]> Signed-off-by: Lukas Monkevicius <[email protected]>
Signed-off-by: Lukas Monkevicius <[email protected]>
Signed-off-by: Lukas Monkevicius <[email protected]>
Signed-off-by: Lukas Monkevicius <[email protected]>
lukas-unity
force-pushed
the
lukas-unity/add-daemonset-to-statsd-exporter
branch
from
7d8847e to
6a6e63c
Compare
lukas-unity
requested review from
zeritti,
dotdc,
mrueg,
tariq1890,
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
StatsD Exporter helm chart doesn't support running it as a DaemonSet, this can be useful when we can't run it as a sidecar deployment.
Also, adds updates deployment and daemonset with options that are present in other helm charts for consistency
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])