[kube-state-metrics] clusterRoleBinding and clusterRole name overrides #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maven35
force-pushed
the
kube-state-metrics-clusterrole
branch
from
cea8638 to
a2521f0
Compare
|
ready for review @dotdc, @mrueg, @tariq1890 whenever you get a chance. |
|
anyone want to take a look at this? @dotdc, @mrueg, @tariq1890? |
|
@Maven35 Can you fix the trailing spaces? |
Maven35
requested review from
gianrubio,
zeritti,
andrewgkew,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
Maven35
force-pushed
the
kube-state-metrics-clusterrole
branch
from
60e6cb6 to
c186471
Compare
Maven35
force-pushed
the
kube-state-metrics-clusterrole
branch
from
c186471 to
0194d59
Compare
|
Hi @Maven35, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])