[alertmanager] add baseURL value #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using `extraArgs` is possible, `baseURL` is consistent with the Prometheus chart and is more discoverable. The template modification is taken from the prometheus chart. Signed-off-by: Max Gautier <[email protected]>
monotek
approved these changes
May 8, 2024
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
While using `extraArgs` is possible, `baseURL` is consistent with the Prometheus chart and is more discoverable. The template modification is taken from the prometheus chart. Signed-off-by: Max Gautier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
While using
extraArgsis possible,baseURLis consistent with thePrometheus chart and is more discoverable.
The template modification is taken from the prometheus chart.
Checklist
[prometheus-couchdb-exporter])