[prometheus] Improve handling of extra args #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0tbird
force-pushed
the
no-value-extra-args
branch
from
716b8d5 to
6f78fec
Compare
h0tbird
force-pushed
the
no-value-extra-args
branch
2 times, most recently
from
b0237b6 to
e1aaf3e
Compare
h0tbird
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
Signed-off-by: Marc Villacorta <[email protected]>
h0tbird
force-pushed
the
no-value-extra-args
branch
from
48ed2aa to
315d00c
Compare
h0tbird
requested review from
andrewgkew,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
monotek
as code owners
zeritti
approved these changes
May 10, 2024
zeritti
removed request for
andrewgkew,
gkarthiks,
GMartinez-Sisti,
QuentinBisson,
scottrigby and
monotek
zeritti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue this PR fixes
This PR enables the inclusion of additional arguments like
--web.enable-remote-write-receiver, which do not support specifying a value.Before
Notice the trailing
=with no value, this 👆🏼 breaks prometheus.After
Without the trailing
=, prometheus is happy.Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])