[prometheus-snmp-exporter] Allow setting environment variables via envFrom #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional envFrom sections to DaemonSet and Deployment Signed-off-by: Karsten Stöckmann <[email protected]>
walker-tom
requested changes
Apr 13, 2024
Signed-off-by: Karsten Stöckmann <[email protected]>
|
Awesome, thanks for approving. 🙂 |
wilfriedroset
pushed a commit
to wilfriedroset/helm-charts
that referenced
this pull request
May 8, 2024
…vFrom (prometheus-community#4441) * Allow setting environment variables - Add optional envFrom sections to DaemonSet and Deployment Signed-off-by: Karsten Stöckmann <[email protected]> * Add example for envFrom Signed-off-by: Karsten Stöckmann <[email protected]> --------- Signed-off-by: Karsten Stöckmann <[email protected]> Co-authored-by: Karsten Stöckmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Miouge1 @xiu @walker-tom
What this PR does / why we need it
Allow setting an optional
envFromsection in DaemonSet or Deployment in order to be able to inject secrets as environment variables to be expanded by the exporter.Which issue this PR fixes
Checklist
[prometheus-couchdb-exporter])