[prometheus] Fix configMapAnnotations for Prometheus server #4432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Ivankovic Milosevic <[email protected]>
Signed-off-by: Petar Ivankovic Milosevic <[email protected]>
SirTediousOfFoo
requested review from
gianrubio,
naseemkullah,
Xtigyro,
zanhsieh and
zeritti
as code owners
zeritti
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Thank you, @SirTediousOfFoo, for your PR. Please, see my comments below.
Keeping to better Helm style Co-authored-by: zeritti <[email protected]> Signed-off-by: Petar Ivanković Milošević <[email protected]>
|
Guess I shouldn't close until someone merges this, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes generation of Helm chart that was broken as a result of not testing a previously merged change. Currently configmap annotations can not be added because the
withclause is used and scope isn't changed.Which issue this PR fixes
Fixes oversight made in #4248 for which there is no specific issue at the moment.
Special notes for your reviewer
My first time contributing here, please be gentle if I missed something.
Checklist
[prometheus-couchdb-exporter])