Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus-json-exporter]: Allow additional container args and service monitor relabelings #4408

Merged
merged 5 commits into from
Jun 27, 2024

Conversation

faisal-khalique
Copy link
Contributor

What this PR does / why we need it

  • Adds the option to pass arguments to the container. Could be needed for many reason. For example collecting logstash metrics with many pipelines where the pipeline definitions vary based on environment. Having the option of providing argument --config.file will greatly simplify such deployments. Considering future use cases, adding an array instead of just specifying the argument --config.file now
  • Add additional relabelings for service-monitor which can be used to drop unwanted labels from the metrics like container, pod, etc.

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

@faisal-khalique
Copy link
Contributor Author

@zanhsieh - can you please check this PR?

@QuentinTournier40
Copy link
Contributor

Hey, what is the progress of this pr?

@zanhsieh zanhsieh merged commit 96c694a into prometheus-community:main Jun 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants