[prometheus-adapter] allow using cluster roles for auth reader #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-vibin
requested review from
hectorj2f,
MattiasGees and
steven-sheehy
as code owners
Signed-off-by: vsternad <[email protected]>
|
Hi @hectorj2f, @MattiasGees, @steven-sheehy could you please check this out 🙂 |
steven-sheehy
requested changes
Apr 2, 2024
Signed-off-by: vsternad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When deploying the Prometheus Adapter in a Namespace the
auth-readerrole is still created in thekube-systemnamespace. Deploying intokube-systemis not wanted for a lot of enterprise clusters.This give the option to deploy the
auth-readerrole as a cluster role rather then a normal role. Now the User can easily deploy everything into one namespaceWhich issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])